Add FilterPushdown support to spark data source#7785
Draft
robert3005 wants to merge 2 commits intodevelopfrom
Draft
Add FilterPushdown support to spark data source#7785robert3005 wants to merge 2 commits intodevelopfrom
robert3005 wants to merge 2 commits intodevelopfrom
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will degrade performance by 10.6%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | take_10k_first_chunk_only |
270.8 µs | 226 µs | +19.83% |
| ⚡ | Simulation | take_10k_dispersed |
284.8 µs | 239.9 µs | +18.73% |
| ⚡ | Simulation | patched_take_10k_first_chunk_only |
302.4 µs | 272.1 µs | +11.13% |
| ⚡ | Simulation | patched_take_10k_dispersed |
316 µs | 285.7 µs | +10.62% |
| ⚡ | Simulation | patched_take_10k_adversarial |
259 µs | 228.8 µs | +13.21% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
246.1 ns | 275.3 ns | -10.6% |
Comparing rk/sparkfilterpushdown (8511f8b) with develop (d3ff1f1)
Footnotes
-
138 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add spark filter pushdown to spark datasource
Signed-off-by: Robert Kruszewski github@robertk.io